-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/svc kernel #220
Fix/svc kernel #220
Conversation
- Change predict to use predict_proba instead for QSVM
- add multiclass FVT for QSVM
- use predict_proba inside for qsvm predictions - add multiclass test for MDM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok for me, but documentation build failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I added some notes on the comments.
- only apply softmax on predict (remove useless overriden method predict_proba inside QSVM).
- fix titles
Thank you both for the review :) This bug was hard to find, and I will try to proceed (in next PRs) with the following improvement of our Ci:
|
This PR fixes the pipeline with Quantum SVM:
predict_proba
+softmax
rather thanpredict